snuyanzin commented on code in PR #27616:
URL: https://github.com/apache/flink/pull/27616#discussion_r2839582371
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/OverAggregateTest.scala:
##########
@@ -492,9 +492,11 @@ class OverAggregateTest extends TableTestBase {
|FROM MyTable
""".stripMargin
- assertThatThrownBy(() => util.verifyExecPlan(sql))
- .hasRootCauseMessage("CHARACTER type is not allowed for window boundary")
- .hasRootCauseInstanceOf(classOf[ValidationException])
+ assertThatExceptionOfType(classOf[RuntimeException])
+ .isThrownBy(() => util.verifyExecPlan(sql))
+ .havingRootCause()
+ .withMessage("CHARACTER type is not allowed for window boundary")
+ .isExactlyInstanceOf(classOf[ValidationException])
}
Review Comment:
It looks like the previous approach didn't check the last statement
```scala
.hasRootCauseInstanceOf(classOf[ValidationException])
```
it was just ignored...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
