davidradl commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/53#discussion_r2891108174
##########
.github/workflows/ci.yml:
##########
@@ -113,6 +113,10 @@ jobs:
if: ${{ inputs.optional_maven_profiles }}
run: echo "MVN_COMMON_OPTIONS=${MVN_COMMON_OPTIONS} -P ${{
inputs.optional_maven_profiles }}" >> $GITHUB_ENV
+ - name: "Set java11 compile target if required"
+ if: ${{ matrix.jdk == 11 }}
Review Comment:
After a [slack
discussion](https://apache-flink.slack.com/archives/C09S4GG5M5J/p1772727835076929?thread_ts=1771856266.150759&cid=C09S4GG5M5J)
After this change :
- jdk 11 in the matrix will now be run with the java 11 target
- jdk 17 in the matrix will run with the default 17 target
- jdk 21 will run with the default 17 target, which will work as 17 < 21.
The question is - shouldn't jdk 21 run with a java 21 target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
