ferenc-csaky commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/53#discussion_r2914164710
##########
.github/workflows/ci.yml:
##########
@@ -113,6 +113,10 @@ jobs:
if: ${{ inputs.optional_maven_profiles }}
run: echo "MVN_COMMON_OPTIONS=${MVN_COMMON_OPTIONS} -P ${{
inputs.optional_maven_profiles }}" >> $GITHUB_ENV
+ - name: "Set java11 compile target if required"
+ if: ${{ matrix.jdk == 11 }}
Review Comment:
I am wondering why that was not necessary previously when the default was
jdk8 and if we can configure this in the POM without touching the CI. But
releasing a parent is way more hard than updating the CI, so to fix this in
short-term, this cannot hurt.
For the JDK21 debate, that also requires a parent connector release, so on
the longer-term IMO it makes sense to add a `java21-target`, but not feasible
short-term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
