tomncooper commented on code in PR #53:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/53#discussion_r2918801489
##########
.github/workflows/ci.yml:
##########
@@ -113,6 +113,10 @@ jobs:
if: ${{ inputs.optional_maven_profiles }}
run: echo "MVN_COMMON_OPTIONS=${MVN_COMMON_OPTIONS} -P ${{
inputs.optional_maven_profiles }}" >> $GITHUB_ENV
+ - name: "Set java11 compile target if required"
+ if: ${{ matrix.jdk == 11 }}
Review Comment:
I think that before the default source and target was 8 so all later JDKs
could handle than. Now that Java 17 is the target, JDK 11 naturally can't
target that.
So should we push this fixed Connector CI workflow and add the java21-target
to the next parent-pom release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
