[
https://issues.apache.org/jira/browse/FLINK-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834194#comment-15834194
]
ASF GitHub Bot commented on FLINK-5224:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3118#discussion_r97284915
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -326,6 +346,52 @@ class CodeGenerator(
}
/**
+ * Generates a [[TableFunctionCollector]] that can be passed to Java
compiler.
+ *
+ * @param name Class name of the table function collector. Must not be
unique but has to be a
+ * valid Java class identifier.
+ * @param bodyCode body code for the collector method
+ * @param returnType The type information of the element collected by
the collector
+ * @return instance of GeneratedFunction
+ */
+ def generateTableFunctionCollector(
+ name: String,
+ bodyCode: String,
+ returnType: TypeInformation[Any])
+ : GeneratedFunction[TableFunctionCollector[Any]] = {
--- End diff --
I would introduce a new `GeneratedCollector` class as this is actually not
a Flink `Function`.
> Improve UDTF: emit rows directly instead of buffering them
> ----------------------------------------------------------
>
> Key: FLINK-5224
> URL: https://issues.apache.org/jira/browse/FLINK-5224
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
>
> This needs to code generate a `Collector` and register it into instance of
> {{TableFunction}}, and emit the rows generated by the UDTF directly instead
> of buffering them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
