[
https://issues.apache.org/jira/browse/FLINK-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834193#comment-15834193
]
ASF GitHub Bot commented on FLINK-5224:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3118#discussion_r97280842
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CorrelateFlatMapRunner.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime
+
+import org.apache.flink.api.common.functions.{FlatMapFunction,
RichFlatMapFunction}
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.api.java.typeutils.ResultTypeQueryable
+import org.apache.flink.configuration.Configuration
+import org.apache.flink.table.codegen.Compiler
+import org.apache.flink.util.Collector
+import org.slf4j.{Logger, LoggerFactory}
+
+class CorrelateFlatMapRunner[IN, OUT](
+ flatMapName: String,
+ flatMapCode: String,
+ collectorName: String,
+ collectorCode: String,
+ @transient returnType: TypeInformation[OUT])
+ extends RichFlatMapFunction[IN, OUT]
+ with ResultTypeQueryable[OUT]
+ with Compiler[Any] {
+
+ val LOG: Logger = LoggerFactory.getLogger(this.getClass)
+
+ private var function: FlatMapFunction[IN, OUT] = _
+ private var collector: TableFunctionCollector[_] = _
+
+ override def open(parameters: Configuration): Unit = {
+ LOG.debug(s"Compiling TableFunctionCollector: $collectorName \n\n
Code:\n$collectorCode")
--- End diff --
I had a look into the generated code. It seems that the
`TableFunctionCollector` contains another `TableFunctionCollector` instance
variable.
> Improve UDTF: emit rows directly instead of buffering them
> ----------------------------------------------------------
>
> Key: FLINK-5224
> URL: https://issues.apache.org/jira/browse/FLINK-5224
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
>
> This needs to code generate a `Collector` and register it into instance of
> {{TableFunction}}, and emit the rows generated by the UDTF directly instead
> of buffering them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
