[ 
https://issues.apache.org/jira/browse/FLINK-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834189#comment-15834189
 ] 

ASF GitHub Bot commented on FLINK-5224:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3118#discussion_r97095042
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -160,6 +165,19 @@ class CodeGenerator(
       }
     
       /**
    +    * @return code block of constructor statements of the function
    +    */
    +  def reuseConstructorCode(funcName: String): String = {
    --- End diff --
    
    I would replace `funcName` with `className`.


> Improve UDTF: emit rows directly instead of buffering them
> ----------------------------------------------------------
>
>                 Key: FLINK-5224
>                 URL: https://issues.apache.org/jira/browse/FLINK-5224
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> This needs to code generate a `Collector` and register it into instance of 
> {{TableFunction}}, and emit the rows generated by the UDTF directly instead 
> of buffering them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to