snuyanzin commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3221571681
##########
flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java:
##########
@@ -70,20 +70,20 @@ public class HiveCatalogTest {
private static HiveCatalog hiveCatalog;
private final ObjectPath tablePath = new ObjectPath("default", "test");
- @BeforeClass
+ @BeforeAll
public static void createCatalog() {
hiveCatalog = HiveTestUtils.createHiveCatalog();
hiveCatalog.open();
}
- @AfterClass
+ @AfterAll
public static void closeCatalog() {
Review Comment:
do we still need method marked with junit5's `BeforeAll`, `AfterAll`, `Test`
public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]