snuyanzin commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3224067245
##########
flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java:
##########
@@ -51,21 +50,19 @@
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
/** Test for {@link HiveCatalog} created by {@link HiveCatalogFactory}. */
-public class HiveCatalogFactoryTest extends TestLogger {
+class HiveCatalogFactoryTest {
Review Comment:
this drops junit4's logger however doesn't add anything from junit5
I guess we should use `@ExtendWith(TestLoggerExtension.class)`
like for instance in `ImmutableByteArrayWrapperTest` of main repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
