jlalwani-amazon commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3227643368
##########
flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java:
##########
@@ -51,21 +50,19 @@
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
/** Test for {@link HiveCatalog} created by {@link HiveCatalogFactory}. */
-public class HiveCatalogFactoryTest extends TestLogger {
+class HiveCatalogFactoryTest {
Review Comment:
Note that because TestLoggerExtension is in the
[META-INF/services](https://github.com/apache/flink-connector-hive/blob/main/flink-connector-hive/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension)
file, the extension will auto-register. However, to be consistent with main
repo and other tests, I am adding the declarative registration in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
