Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3128#discussion_r97314949
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
 ---
    @@ -50,12 +51,27 @@
        private MetricDumpSerialization() {
        }
     
    +   public static class MetricSerializationResult {
    --- End diff --
    
    Can you add a short class level comment about why we added this? The 
problem with determining number of metrics before hand etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to