eskabetxe commented on code in PR #4387: URL: https://github.com/apache/flink-cdc/pull/4387#discussion_r3306830397
########## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/reader/PostgresSourceStreamFetcher.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.postgres.source.reader; + +import org.apache.flink.cdc.connectors.base.source.reader.external.FetchTask; +import org.apache.flink.cdc.connectors.base.source.reader.external.IncrementalSourceStreamFetcher; + +import io.debezium.data.Envelope; +import org.apache.kafka.connect.data.Struct; +import org.apache.kafka.connect.source.SourceRecord; + +/** + * Stream fetcher for Postgres. When {@code includeLogicalMessages} is enabled, lets {@code + * pg_logical_emit_message} records (op="m") bypass table-based watermark filtering, since logical + * messages are not bound to a table. + */ +public class PostgresSourceStreamFetcher extends IncrementalSourceStreamFetcher { + + private final boolean includeLogicalMessages; + + public PostgresSourceStreamFetcher( + FetchTask.Context taskContext, int subtaskId, boolean includeLogicalMessages) { + super(taskContext, subtaskId); + this.includeLogicalMessages = includeLogicalMessages; + } + + @Override + protected boolean shouldEmit(SourceRecord sourceRecord) { + if (includeLogicalMessages && isLogicalMessage(sourceRecord)) { + return true; + } + return super.shouldEmit(sourceRecord); + } + + static boolean isLogicalMessage(SourceRecord record) { + if (record.value() instanceof Struct) { + Struct struct = (Struct) record.value(); Review Comment: added a prefix filtering in same way we have tablesInclued logical-message.prefixes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
