jlalwani-amazon commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3313197735
##########
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserQB.java:
##########
@@ -76,7 +75,7 @@ public class HiveParserQB {
*/
private int numSubQueryPredicates;
- private CreateTableDesc createTableDesc;
+ private Object createTableDesc;
Review Comment:
That's the idea behind HiveSHim400 being in a seperate module. I can
refactor the Semantic analyzer to move parts of it to other module. I don't
want to duplicate the entire code. Can we do this refactoring is a follow up
PR, to avoid holding up this PR. The build also needs refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
