jlalwani-amazon commented on code in PR #37: URL: https://github.com/apache/flink-connector-hive/pull/37#discussion_r3313215738
########## flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserQBSubQuery.java: ########## @@ -25,7 +25,7 @@ import org.apache.calcite.plan.RelOptCluster; import org.apache.calcite.tools.FrameworkConfig; -import org.apache.hadoop.hive.common.ObjectPair; +import org.apache.commons.lang3.tuple.MutablePair; Review Comment: HiveParserCalcitePlanner.java, HiveParserBaseSemanticAnalyzer.java and HiveParserQBSubQuery.java use this. Out of these HiveParserCalcitePlanner and HiveParserBaseSemanticAnalyzer are mutating it. We can ofcourse refactor it to clone ImmutablePair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
