jlalwani-amazon commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-hive/pull/37#discussion_r3313124893
##########
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:
##########
@@ -1664,9 +1663,33 @@ private void getMetaData(HiveParserQB qb) throws
HiveException {
Path location;
// If the CTAS query does specify a location,
use the table
// location, else use the db location
- if (qb.getTableDesc() != null
- && qb.getTableDesc().getLocation() !=
null) {
- location = new
Path(qb.getTableDesc().getLocation());
+ // Note: getTableDesc() returns Object (Hive 4
relocated
Review Comment:
Alternatively, we can implement shims for PrincipalDesc and CreateTableDesc.
That should make this code more understandable but will add another level of
indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
