weiqingy commented on code in PR #657:
URL: https://github.com/apache/flink-agents/pull/657#discussion_r3314252013
##########
api/src/main/java/org/apache/flink/agents/api/agents/AgentExecutionOptions.java:
##########
@@ -47,4 +47,21 @@ public class AgentExecutionOptions {
public static final ConfigOption<Boolean> RAG_ASYNC =
new ConfigOption<>("rag.async", Boolean.class, true);
+
+ public static final ConfigOption<Long> SHORT_TERM_MEMORY_STATE_TTL_MS =
+ new ConfigOption<>("short-term-memory.state-ttl.ms", Long.class,
0L);
Review Comment:
Nit: 0L doubles as the "TTL disabled" sentinel, but that contract only
lives in OperatorStateManager.maybeEnableShortTermMemoryTTL. A one-line javadoc
here — e.g. "Set to a positive value in milliseconds to enable TTL; 0 (the
default) disables it" — would spare future readers a trip into the runtime.
Same applies to the two enum options below: worth noting they're only consulted
when TTL_MS > 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
