twalthr commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-kafka/pull/258#discussion_r3318964094
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/DynamicKafkaRecordSerializationSchema.java:
##########
@@ -285,4 +289,14 @@ private <T> T readMetadata(RowData consumedRow,
KafkaDynamicSink.WritableMetadat
}
return (T) metadata.converter.read(consumedRow, pos);
}
+
+ private static @Nullable List<Header> resolveHeaders(
+ @Nullable List<Header> mapHeaders, @Nullable List<Header>
arrayHeaders) {
+ if (mapHeaders != null && arrayHeaders != null) {
+ throw new IllegalStateException(
Review Comment:
If the user asks for both we can simply provide it, in which case we read
twice. Not our problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
