leonardBang commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-kafka/pull/258#discussion_r3323424712
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSource.java:
##########
@@ -623,6 +625,42 @@ public Object read(ConsumerRecord<?, ?> record) {
}
}),
+ /**
+ * Wire-faithful alternative to {@code headers}: preserves duplicate
keys and insertion
+ * order using {@code ARRAY<ROW<key STRING, value BYTES>>} instead of
a lossy MAP.
+ */
+ MULTI_HEADERS(
+ "multi-headers",
Review Comment:
Naming nit on `multi-headers`: the prefix multi- is a bit unusual since
headers is already plural, and the real selling point is "wire-faithful
(preserves order + duplicates)" rather than "multi" from my poor English. Two
alternatives worth considering:
- `header-list` — pairs nicely with the MAP-typed headers; the name itself
hints at the data structure.
- `raw-headers` — emphasizes that this version is loss-free w.r.t. the Kafka
wire format.
No strong opinion either way, but I'd lean toward `header-list` for symmetry
with headers. Curious what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
