MartijnVisser opened a new pull request, #28593:
URL: https://github.com/apache/flink/pull/28593

   ## What is the purpose of the change
   
   Upgrade the Flink web dashboard from Angular 20.1.3 / ng-zorro-antd 20.1.0 
to the
   latest LTS Angular (21.2.17) and the matching stable ng-zorro-antd (21.3.2). 
This
   brings the framework and its lint toolchain current, regenerates the 
dependency
   lockfile (resolving the outstanding npm security advisories that Dependabot 
had been
   filing individually against this module), and fixes the stale NOTICE file.
   
   ## Brief change log
   
     - Bump all `@angular/*` 20.1.3 -> 21.2.17, `ng-zorro-antd` 20.1.0 -> 
21.3.2, and
       TypeScript 5.8 -> 5.9 via `ng update` (runs the control-flow and zone
       change-detection migrations); `@angular/cdk` 21 is pulled in transitively
     - Align the lint chain that tracks the Angular major: `@angular-eslint/*` 
-> 21.4.0,
       `@typescript-eslint/*` -> 8.62.x (eslint stays on 8.57; eslint 9 / flat 
config is a
       follow-up), and `@types/node` -> 22 to match the build's Node runtime
     - Regenerate `package-lock.json` against the public npm registry (also 
drops
       third-party-mirror URLs that had crept into the committed lockfile) and 
regenerate
       `NOTICE` (which still listed Angular 18)
     - Convert the one template the migration could not auto-convert (duplicate 
`#badges`
       ng-template) from `*ngIf`/`*ngFor` to `@if`/`@for`, and use stable 
`@for` track
       expressions where the migration defaulted to track-by-identity (fixes 
NG0956 /
       NG0955 dev warnings)
     - Build cleanup: remove the obsolete `HUSKY_SKIP_INSTALL` env var and 
deprecated
       `npm ci` flags from `flink-runtime-web/pom.xml` (husky was removed in 
FLINK-33939),
       and bump the documented Node minimum in the README to Angular 21's floor
   
   Node/npm pins (v22.16.0 / 10.9.0) and `frontend-maven-plugin` (1.15.1) 
already satisfy
   Angular 21 and are unchanged. The existing webpack (`:browser`) builder is 
kept;
   migrating to the esbuild application builder, the prettier 3 / stylelint 17 
tooling
   refresh, and eslint 9 are left as separate follow-ups.
   
   ## Verifying this change
   
   This change is a dependency upgrade verified by the build/lint gate plus 
manual testing:
   
     - `flink-runtime-web` builds via Maven, where `frontend-maven-plugin` runs 
`npm ci`
       and `npm run ci-check` (eslint + stylelint + production build) using the 
pinned
       Node 22.16.0 / npm 10.9.0
     - Manually verified against a local standalone cluster running a 
`TopSpeedWindowing`
       streaming job plus a jar submitted from the UI: clicked through 
Overview, Job
       list/detail (DAG, Timeline, Exceptions, Checkpoints, Backpressure, 
FlameGraph,
       Watermarks, Accumulators, Subtasks), JobManager (Logs, Configuration, 
Metrics,
       Thread Dump, Profiler), TaskManager views, and the Submit page, with the 
browser
       console open and free of errors
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes** (frontend npm
       dependencies: Angular 20->21, ng-zorro-antd 20->21, TypeScript 5.8->5.9 
and
       transitive updates; `NOTICE` regenerated accordingly)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager, Checkpointing,
       Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to