Laffery commented on PR #28593:
URL: https://github.com/apache/flink/pull/28593#issuecomment-4856111838

   > Given [FLINK-40028](https://issues.apache.org/jira/browse/FLINK-40028) is 
scoped to the Angular/ng-zorro version bump, I'd propose keeping the templates 
on ngIf/ngFor here (as master) and doing the control-flow migration + prettier 
3 together as a dedicated follow-up, where the reformat can be reviewed on its 
own. Would that work for you, or do you feel strongly it should all land in 
this PR?
   
   It works for me!
   
   What's more, I suggest to upgrade eslint to v9 together in the follow-up PR, 
https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/eslint.config.mjs could 
be an example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to