MartijnVisser commented on PR #28593: URL: https://github.com/apache/flink/pull/28593#issuecomment-4853325082
@Laffery Thanks. You're right the control-flow blocks are poorly formatted, but the cause isn't the lint-staged removal. It's that prettier 2.6.2 (what master resolves) doesn't support Angular `@if/@for` formatting; that landed in prettier 3. I verified `npm run lint:fix` on this branch is a no-op (it can't reindent them), whereas prettier 3 does reindent them properly. The catch: the same prettier 3 also reformats the ASF license-header comments across every template, which is exactly the churn flagged on this PR earlier (#28593 discussion) and is really the FLINK-39587 / #28440 territory. So "format the whole project" is a prettier-3 upgrade + project-wide reformat (with a `.git-blame-ignore-revs` entry), not a small `lint:fix`. Given FLINK-40028 is scoped to the Angular/ng-zorro version bump, I'd propose keeping the templates on `ngIf/ngFor` here (as master) and doing the control-flow migration + prettier 3 together as a dedicated follow-up, where the reformat can be reviewed on its own. Would that work for you, or do you feel strongly it should all land in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
