MartijnVisser commented on PR #27745: URL: https://github.com/apache/flink/pull/27745#issuecomment-4905606098
From a quick glance, there are a couple of things that should at least be considered: 1. Don't forget to update the `NOTICE` file, you can use `web-dashboard/dev/generate_notice.sh` for it 2. Look out for the `package-lock.json` if you rebase, you probably should run `npm install` 3. Monaco is used quite extensive (like all log/stdout/thread-dump views) for both JobManager and TaskManager pages. Would be great if you can smoke test them 4. On `getAction(...)?.run()`: the optional chaining also silently no-ops if the action IDs don't resolve in 0.55. Happy to help with the review when you've worked on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
