featzhang commented on code in PR #27745: URL: https://github.com/apache/flink/pull/27745#discussion_r3541237054
########## flink-runtime-web/src/main/resources/META-INF/NOTICE: ########## @@ -45,6 +45,7 @@ The Apache Software Foundation (http://www.apache.org/). | @dagrejs/graphlib | 4.0.1 | MIT | | @standard-schema/spec | 1.1.0 | MIT | | @types/d3-timer | 2.0.3 | MIT | +| @types/trusted-types | 2.0.7 | MIT | Review Comment: thanks for keeping notice in sync with the new transitive dep. one thing: dompurify shows up as (MPL-2.0 OR Apache-2.0) here, just double-check that matches what the release checklist expects, since the LICENSE file in the source dist needs the same entry. ########## flink-runtime-web/web-dashboard/src/app/pages/task-manager/thread-dump/task-manager-thread-dump.component.ts: ########## @@ -89,8 +89,8 @@ export class TaskManagerThreadDumpComponent implements OnInit, OnDestroy { } if (results.length > 0) { editor.setSelection(results[0].range); - editor.getAction('actions.find').run(); Review Comment: nice, the optional chaining here makes sense. out of curiosity, do you know which monaco version dropped the non-null return on getAction? since 0.31 -> 0.55 crosses several majors, it'd help to note in the description that this was the only api breakage you hit, so reviewers know the bump is contained. ########## flink-runtime-web/web-dashboard/package.json: ########## @@ -24,7 +24,7 @@ "core-js": "^3.49.0", "d3": "^7.9.0", "d3-flame-graph": "^5.0.0", - "monaco-editor": "^0.31.1", + "monaco-editor": "^0.55.1", Review Comment: this is a big jump (0.31 -> 0.55, multiple majors). the dashboard only uses monaco in this one component so the surface is small, but worth confirming in the description that no other monaco apis are consumed. also did you run a full ng build to be sure nothing else in the bundle broke with the newer editor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
