gkomlossi commented on PR #27745: URL: https://github.com/apache/flink/pull/27745#issuecomment-4906921186
Thanks a lot for all your comments. I've updated the NOTICE file as well. I have rebased my branch and redo/retest the change: After updating the Monaco version in the `package.json` I regenerated the `package-lock.json` file. The optional chaining was needed because of a compilation failure. Then I rebuilt/started it and while running a job I checked: 1. **Task Manager → Thread Dump** - Confirmed the Monaco editor loads and shows thread dump text - Clicked reload and verify it refreshes - Tested the download link 2. **Backpressure → Dump link** - Tested vertexName query param + Monaco search - Confirmed the editor highlights/finds the matching thread name 3. **Job Manager → Thread Dump** - Sanity check for Monaco Anything else comes to your mind, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
