davidradl commented on code in PR #28752:
URL: https://github.com/apache/flink/pull/28752#discussion_r3612901513
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -176,6 +176,12 @@
<td>Boolean</td>
<td>Forces unaligned checkpoints, particularly allowing them for
iterative jobs.</td>
</tr>
+ <tr>
+
<td><h5>execution.checkpointing.unaligned.interruptible-timers.emit-intermediate-watermarks</h5></td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>When interruptible timers are enabled and firing due timers
for a watermark advance is interrupted before completing, an intermediate
watermark reflecting the progress made so far is emitted, at most as often as
configured by 'pipeline.auto-watermark-interval', so that downstream operators
are not starved of watermark progress during a long-running catch-up. Set to
false to disable intermediate watermark emission.</td>
Review Comment:
I find this sentence difficult to parse.
- maybe point to the config that enables the interruptable timers.
- for "firing due timers" is this "firing due to timers"
- links to the concepts would help
- When interruptible timers are enabled, It would be helpful to detail when
this flag should be used and when it should not and whether there are side
effects from using / not using it.
- this does not mention the unaligned part of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
