davidradl commented on code in PR #28752:
URL: https://github.com/apache/flink/pull/28752#discussion_r3612949406
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##########
@@ -71,6 +71,13 @@ public class InternalTimerServiceImpl<K, N> implements
InternalTimerService<N> {
*/
protected long currentWatermark = Long.MIN_VALUE;
+ /**
+ * Unlike {@link #currentWatermark}, which is set to the requested target
before firing starts,
Review Comment:
This comment does not seem to match the code. The code is a private long,
but the comment talks of it being safe to expose.
nit: finish -> finishes
when you says "actually finish firing" - what does this actually mean. This
implies the firing process has a begin and end and potentially something in the
middle. It would be good to clarify this further to help the reader undertand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
