davidradl commented on code in PR #28752:
URL: https://github.com/apache/flink/pull/28752#discussion_r3612960658
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##########
@@ -339,10 +350,18 @@ public boolean tryAdvanceWatermark(
eventTimeTimersQueue.poll();
triggerTarget.onEventTime(timer);
taskIOMetricGroup.getNumFiredTimers().inc();
+ // Other timers due at exactly this timestamp may still be
unfired, so only claim
+ // progress strictly below it.
+ reachedWatermark = timer.getTimestamp() - 1;
// Check if we should stop advancing after at least one iteration
to guarantee progress
// and prevent a potential starvation.
interrupted = shouldStopAdvancingFn.test();
}
+ if (!interrupted) {
+ // Fully drained: nothing due at or below time remains, regardless
of the last fired
Review Comment:
I do not understand what fully drained means. I assume this is just normal
watermark processing that was not interrupted. Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
