weiqingy commented on code in PR #938: URL: https://github.com/apache/flink-agents/pull/938#discussion_r3780342185
########## api/src/main/java/org/apache/flink/agents/api/subagent/BaseSubagentCallable.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.subagent; + +import org.apache.flink.agents.api.context.DurableCallable; + +/** + * Convenience base for the {@link DurableCallable} returned by {@code asAsyncCallable}. + * + * <p>Keys the durable call by the framework-assigned identity as {@code sessionId#callId} (the + * {@link SubagentSetup} contract) and captures exceptions thrown by {@link #callInternal()} into + * {@link Result#error(Exception)}, so failures are reported through the result rather than thrown. + * Implementations only provide {@link #callInternal()}. + */ +public abstract class BaseSubagentCallable implements DurableCallable<Result> { + + private final String sessionId; + private final String callId; + + protected BaseSubagentCallable(String sessionId, String callId) { Review Comment: Your commits already made the call here. 2 plus 3 is where I'd have landed too, so nothing further from me on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
