1996fanrui commented on code in PR #29065:
URL: https://github.com/apache/flink/pull/29065#discussion_r3936615285
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java:
##########
@@ -320,6 +332,25 @@ abstract class AbstractSpillingHandler extends
AbstractInputChannelRecoveredStat
this.maxSegmentSizeBytes = maxSegmentSizeBytes;
this.baseDir =
Paths.get(spillTmpDirectories[0], "flink-channel-spill-" +
UUID.randomUUID());
+ this.cancelables = checkNotNull(cancelables);
+ }
+
+ private void deleteSpillFiles() throws IOException {
+ IOException firstError = null;
+ for (Path file : files) {
Review Comment:
Good catch — switched to `deleteDirectoryQuietly`(best-effort/quiet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
