rkhachatryan commented on code in PR #29065:
URL: https://github.com/apache/flink/pull/29065#discussion_r3978342120
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/SequentialChannelStateReaderImpl.java:
##########
@@ -103,6 +104,11 @@ public Optional<FetchedChannelState> readInputData(
// stateHandler.close() (above) has flushed the filter writer and
published the
// produced spill file, so read getProducedChannelState() after
the close completes.
return Optional.ofNullable(stateHandler.getProducedChannelState());
+ } catch (Throwable t) {
+ // The state was not handed off, so no drainer will release its
spill files: delete
+ // them here (quietly, so the original failure is not masked).
+ IOUtils.closeQuietly(stateHandler.getProducedChannelState());
Review Comment:
I think we are back to this
[issue](https://github.com/apache/flink/pull/29065#discussion_r3927884223) now:
the failure might happen before the
`AbstractSpillingHandler.producedChannelState` is assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
