twalthr commented on code in PR #29103:
URL: https://github.com/apache/flink/pull/29103#discussion_r3950851443
##########
flink-core/src/main/java/org/apache/flink/types/variant/Variant.java:
##########
@@ -171,6 +172,14 @@ public interface Variant extends Serializable {
*/
byte[] getBytes() throws VariantTypeException;
+ /**
+ * Get the scalar value of variant as UUID, if the variant type is {@link
Type#UUID}.
+ *
+ * @throws VariantTypeException If this variant is not a scalar value or
is not {@link
+ * Type#UUID}.
+ */
+ UUID getUUID() throws VariantTypeException;
Review Comment:
```suggestion
UUID getUuid() throws VariantTypeException;
```
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantBuilder.java:
##########
@@ -168,6 +169,13 @@ public Variant of(LocalTime localTime) {
return builder.build();
}
+ @Override
+ public Variant of(UUID uuid) {
+ BinaryVariantInternalBuilder builder = new
BinaryVariantInternalBuilder(false);
+ builder.appendUUID(uuid);
Review Comment:
```suggestion
builder.appendUuid(uuid);
```
> The Modern/Google Style: appendUuid
Modern style guides—most notably the Google Java Style Guide—mandate that
acronyms should be treated as regular words. Under this rule, "UUID" becomes
"Uuid", making your method appendUuid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
