laughingman7743 commented on PR #156: URL: https://github.com/apache/flink-connector-jdbc/pull/156#issuecomment-5795819708
@MartijnVisser Thanks a lot for the thorough review! I've rebased onto the latest main and addressed all comments. As requested, the history is now 5 commits, all prefixed with `[FLINK-37288][jdbc]`. The 3 core changes each have their own commit, followed by the Spanner module and the docs. Besides the review items, I bumped `google-cloud-spanner-jdbc` from 2.26.1 to 2.44.0 and the emulator image to 1.5.58. Two things were needed for the new driver: - Newer drivers return parameterized type names such as `ARRAY<BOOL>` from `getColumnTypeName`, so the catalog type mapper now strips the type parameters. - Since 2.32.0, all connections share a single multiplexed session. The emulator only supports one read-write transaction at a time, so `testUpsert` failed with parallel sink subtasks on the emulator. The Spanner ITCase now runs that test with parallelism 1. This limitation is specific to the emulator; real Spanner supports concurrent transactions on multiplexed sessions. Locally, the core, Spanner and architecture tests pass on JDK 17. Could you please approve the CI workflow when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
