laughingman7743 commented on PR #156: URL: https://github.com/apache/flink-connector-jdbc/pull/156#issuecomment-5797418837
@MartijnVisser Thanks for approving the CI run. The Flink 2.3.0 job failed in `SpannerDynamicTableSinkITCase`, which I've fixed and force-pushed. The history is still the same 5 commits. **Cause:** Since Flink 2.3.0 (FLIP-558), writing insert-only data into a sink table with a primary key requires an `ON CONFLICT` clause. Spanner tables always have a primary key, so `testAppend`, `testReal`, `testArray` and `testTimestampLtzWithNonUtcDefaultTimeZone` hit the new validation. FLINK-40725 only adjusted the tests of other dialects, and I had only run the tests locally against the default Flink 2.1.3, so I missed this. **Fix (tests only):** - `JdbcDynamicTableSinkITCase` (core): made `isFlip558Enabled()` protected and added an `appendOnConflictClause()` hook that `testAppend` appends to its INSERT statement. It returns an empty string by default, so dialects whose append output table has no primary key are unaffected. Their `testAppend` already passed on Flink 2.3.0 in this CI run. - `SpannerDynamicTableSinkITCase`: overrides the hook to return ` ON CONFLICT DO DEDUPLICATE` on Flink >= 2.3, the same clause as FLINK-40725, and uses it in the Spanner-specific sink tests. The core, Spanner and architecture tests now pass locally against both Flink 2.1.3 and 2.3.0. The other failures in that run were not caused by this PR. The Flink 2.1.3 and 2.2.1 jobs were cancelled by fail-fast after the 2.3.0 job failed, and `backwards_compatibility_test (2.0-SNAPSHOT)` failed because Maven Central returned a transient `500 Internal Server Error` while resolving `maven-compiler-plugin`. Could you please approve the workflow run again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
