laughingman7743 commented on code in PR #156:
URL:
https://github.com/apache/flink-connector-jdbc/pull/156#discussion_r4083015939
##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -887,6 +902,7 @@ Flink supports connect to several databases which uses
dialect like MySQL, Oracl
<code>TINYINT(1)</code></td>
<td></td>
<td><code>BOOLEAN</code></td>
+ <td><code>BOOLEAN</code></td>
Review Comment:
Fixed in both en and zh. While checking the table, I also found that the
TIMESTAMP WITH TIMEZONE row was missing its Spanner cell, so I added it. I also
removed the incorrect `NUMERIC` entry for BIGINT UNSIGNED and changed
`TIMESTAMP [(p)]` to `TIMESTAMP`. Every row now has 11 cells.
##########
flink-connector-jdbc-spanner/pom.xml:
##########
@@ -0,0 +1,98 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
Added the ASF headers to `pom.xml` and `SpannerTableRow.java`, and switched
to `testcontainers-jdbc`. The gcloud module turned out to be unused (the tests
use their own `SpannerEmulatorJdbcContainer`), so I dropped it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
