wenjin272 opened a new issue, #1193:
URL: https://github.com/apache/flink-agents/issues/1193

   ### Search before asking
   
   - [x] I searched existing issues for duplicates; related work is linked 
below where applicable.
   
   ### Description
   
   This is a child issue of #1055.
   
   #### Problem
   
   ReActAgent constructors accept a chat-model descriptor, prompt, and output 
schema, but do not expose Skills as a first-class constructor option. Users 
have to know the chat-model descriptor configuration to attach Skills to the 
built-in agent.
   
   #### Proposed direction
   
   Add equivalent Java/Python `skills` constructor support. Agree whether the 
argument accepts registered resource names, resource declarations, or both, and 
document how those resources become available to the agent.
   
   Define how constructor Skills interact with Skills already configured on the 
chat-model descriptor: merge/override behavior, ordering, duplicate/conflicting 
declarations, and whether the supplied descriptor is copied or modified. 
Clarify ownership and precedence of `allowed_commands` so the new convenience 
API does not silently change command permissions.
   
   #### Acceptance criteria
   
   - Java/Python expose equivalent Skills configuration on ReActAgent.
   - Constructor and descriptor settings have deterministic, documented 
combination rules.
   - Tests cover constructor-only, descriptor-only, combined/conflicting 
declarations, and command-policy behavior, including actual Skill availability 
in the ReAct execution path.
   - Examples and applicable YAML-facing semantics remain consistent with the 
resource model.
   
   Relevant code: `api/.../agents/ReActAgent.java`, 
`python/flink_agents/api/agents/react_agent.py`.
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to