wenjin272 commented on issue #1193: URL: https://github.com/apache/flink-agents/issues/1193#issuecomment-6056759672
Thanks for picking this up @da-daken! Merging the two lists with descriptor skills first and constructor skills appended sounds reasonable. Repeated skill names can be deduplicated while preserving that order. For the constructor API, I suggest supporting both: - A list of skill names, referencing skills from sources registered through the existing APIs. - A `Skills` object, with the constructor registering its sources and making all skills from those sources available to the agent. Please merge skills into a copy of the chat-model descriptor’s configuration rather than modifying the supplied descriptor or its skills list in place. Users may reuse the same descriptor across multiple agents; adding skills to one agent should not affect another agent or change the caller’s original configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
