da-daken commented on issue #1193: URL: https://github.com/apache/flink-agents/issues/1193#issuecomment-6055604462
hi @wenjin272 If no one has taken this on yet, I'd be happy to finish it. Regarding adding skills via constructor parameters, there are two entry points for adding skills, so both may be configured at the same time. Here is my proposed approach: - Merge the skills from the constructor parameters with the skills from the descriptor. - If they have the same name, just deduplicate them. - For ordering, the descriptor skills can come first, and the constructor-parameter skills can be appended as a supplement. All of the above rules will be clearly documented in comments and documentation. WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
