snuyanzin commented on code in PR #29424:
URL: https://github.com/apache/flink/pull/29424#discussion_r4218387378
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java:
##########
@@ -629,6 +633,10 @@ public AbstractSlicedSliceAssigner(int sliceEndIndex,
SliceAssigner innerAssigne
@Override
public long assignSliceEnd(RowData element, ClockService clock) {
+ if (element.isNullAt(sliceEndIndex)) {
+ throw new IllegalStateException(
+ "Slice end of a sliced input row is null. This is a
bug.");
Review Comment:
>User can't do anything about it, bug on our side.
if somewhere is NPE it is also bug in Flink, however I hardly tend to think
that we need to insert tons of checks for NPE and for every tell that bug in
our side because something is null...
Can we better try to understand cases we come here and why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
