ykisana commented on code in PR #29424:
URL: https://github.com/apache/flink/pull/29424#discussion_r4218220667
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java:
##########
@@ -629,6 +633,10 @@ public AbstractSlicedSliceAssigner(int sliceEndIndex,
SliceAssigner innerAssigne
@Override
public long assignSliceEnd(RowData element, ClockService clock) {
+ if (element.isNullAt(sliceEndIndex)) {
+ throw new IllegalStateException(
+ "Slice end of a sliced input row is null. This is a
bug.");
Review Comment:
@snuyanzin I tried to follow bug messages in the rest of the repo 'This is
a bug' is found in other places. It's an IllegalStateException. User can't do
anything about it, bug on our side.
Updating to make this more clear though. Let me know if you have suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
