snuyanzin commented on code in PR #29424:
URL: https://github.com/apache/flink/pull/29424#discussion_r4224590655
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnsliceAssigners.java:
##########
@@ -229,7 +229,10 @@ public Collection<TimeWindow> assignWindows(RowData
element, long timestamp)
private TimeWindow createWindow(RowData element) {
if (element.isNullAt(windowStartIndex) ||
element.isNullAt(windowEndIndex)) {
- throw new RuntimeException("RowTime field should not be
null.");
+ throw new IllegalStateException(
+ "Window start or window end of the input row is null. "
+ + "Both should be set by the upstream window
operator. "
+ + "This is a bug. Please file an issue.");
Review Comment:
>I believe this path is unreachable.
it is not a proof, need something more reliable as a proof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
