MartijnVisser commented on code in PR #29410:
URL: https://github.com/apache/flink/pull/29410#discussion_r4228880356
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractNonTimeUnboundedPrecedingOver.java:
##########
@@ -195,6 +199,10 @@ public void open(OpenContext openContext) throws Exception
{
sortKeyEqualiser =
generatedSortKeyEqualiser.newInstance(getRuntimeContext().getUserCodeClassLoader());
+ // Initialize accumulator equaliser
+ accEqualiser =
+
generatedAccEqualiser.newInstance(getRuntimeContext().getUserCodeClassLoader());
Review Comment:
Keep it unconditional. Narrowing it is how BITMAP slipped through, and the
extra copy is cheap next to what this operator already does per insert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
