Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2791#discussion_r99583687
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
---
@@ -112,22 +111,29 @@ void notifySlotAvailable(
* Unregisters an infoMessage listener
*
* @param infoMessageListenerAddress address of infoMessage listener to
unregister from this resource manager
- *
*/
void unRegisterInfoMessageListener(String infoMessageListenerAddress);
/**
* shutdown cluster
+ *
* @param finalStatus
* @param optionalDiagnostics
*/
void shutDownCluster(final ApplicationStatus finalStatus, final String
optionalDiagnostics);
/**
* Gets the currently registered number of TaskManagers.
- *
+ *
* @param leaderSessionId The leader session ID with which to address
the ResourceManager.
* @return The future to the number of registered TaskManagers.
*/
Future<Integer> getNumberOfRegisteredTaskManagers(UUID leaderSessionId);
+
+ /*
+ * Sends the heartbeat to resource manager from task manager
+ *
+ * @param resourceID unique id of the task manager
+ */
+ void sendHeartbeatFromTaskManager(final ResourceID resourceID);
--- End diff --
clearer to name this method `heartbeatFromTaskManager` or
`reportHeartbeatFromTaskManager`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
