Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2791#discussion_r99582640
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRunner.java
 ---
    @@ -55,6 +55,7 @@ public ResourceManagerRunner(
                final ResourceManagerConfiguration resourceManagerConfiguration 
= ResourceManagerConfiguration.fromConfiguration(configuration);
                final SlotManagerFactory slotManagerFactory = new 
DefaultSlotManager.Factory();
                final JobLeaderIdService jobLeaderIdService = new 
JobLeaderIdService(highAvailabilityServices);
    +           final HeartbeatService heartbeatService = new 
HeartbeatService(resourceManagerConfiguration, rpcService.getExecutor());
    --- End diff --
    
    Things which are started outside of the `ResourceManager` should also be 
closed outside of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to