Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2791#discussion_r99582381
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ---
    @@ -831,5 +856,30 @@ public void handleError(Throwable error) {
                        onFatalErrorAsync(error);
                }
        }
    +
    +   private class HeartbeatListenerWithTaskExecutor implements 
HeartbeatListener<Void, Void> {
    +
    +           @Override
    +           public void notifyHeartbeatTimeout(final ResourceID resourceID) 
{
    +                   log.warn("Lost heartbeat with taskExecutor {}, mark the 
taskExecutor as failed ", resourceID);
    +                   runAsync(new Runnable() {
    +                           @Override
    +                           public void run() {
    +                                   
heartbeatService.unmonitorTaskExecutor(resourceID);
    --- End diff --
    
    Why not removing the heartbeat target as part of the `notifyWorkerFailed` 
call?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to