[ 
https://issues.apache.org/jira/browse/FLINK-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854031#comment-15854031
 ] 

ASF GitHub Bot commented on FLINK-4354:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2770#discussion_r99586748
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
 ---
    @@ -129,4 +130,11 @@
         * @return Future acknowledge if the task is successfully canceled
         */
        Future<Acknowledge> cancelTask(ExecutionAttemptID executionAttemptID, 
@RpcTimeout Time timeout);
    +
    +   /**
    +    *  request heartbeat from the resource manager
    +    *
    +    * @param resourceID unique id of the resource manager
    +    */
    +   void requestHeartbeatFromResourceManager(ResourceID resourceID);
    --- End diff --
    
    Same applies here for the naming as well as the outsourcing of this method 
in a dedicated heartbeat interface.


>  Implement TaskManager side of heartbeat from ResourceManager
> -------------------------------------------------------------
>
>                 Key: FLINK-4354
>                 URL: https://issues.apache.org/jira/browse/FLINK-4354
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{ResourceManager}} initiates heartbeat messages via the {{RmLeaderID}}. 
> The {{TaskManager}} transmits its slot availability with each heartbeat. That 
> way, the RM will always know about available slots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to