[
https://issues.apache.org/jira/browse/FLINK-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854028#comment-15854028
]
ASF GitHub Bot commented on FLINK-4354:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99586359
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
---
@@ -122,4 +122,11 @@ void notifySlotAvailable(
* @param optionalDiagnostics
*/
void shutDownCluster(final ApplicationStatus finalStatus, final String
optionalDiagnostics);
+
+ /**
+ * sends the heartbeat to resource manager from task manager
+ * @param resourceID unique id of the task manager
+ * @param payload the payload information of the task manager
+ */
+ void sendHeartbeatFromTaskManager(final ResourceID resourceID, final
Object payload);
--- End diff --
Better to call this method `reportHeartbeatFromTaskManager` or
`heartbeatFromTaskManager`. Maybe we could also introduce a dedicated interface
for this which is inherited by the `ResourceManagerGateway`?
> Implement TaskManager side of heartbeat from ResourceManager
> -------------------------------------------------------------
>
> Key: FLINK-4354
> URL: https://issues.apache.org/jira/browse/FLINK-4354
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{ResourceManager}} initiates heartbeat messages via the {{RmLeaderID}}.
> The {{TaskManager}} transmits its slot availability with each heartbeat. That
> way, the RM will always know about available slots.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
