[ 
https://issues.apache.org/jira/browse/FLINK-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855222#comment-15855222
 ] 

ASF GitHub Bot commented on FLINK-4354:
---------------------------------------

Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2770#discussion_r99737255
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 ---
    @@ -99,6 +101,13 @@ public TaskManagerRunner(
                // Initialize the TM metrics
                
TaskExecutorMetricsInitializer.instantiateStatusMetrics(taskManagerMetricGroup, 
taskManagerServices.getNetworkEnvironment());
     
    +           HeartbeatManagerImpl heartbeatManager = new 
HeartbeatManagerImpl(
    +                   taskManagerConfiguration.getTimeout().toMilliseconds(),
    +                   resourceID,
    +                   executor,
    +                   Executors.newSingleThreadScheduledExecutor(),
    --- End diff --
    
    It is already added in new modifications


>  Implement TaskManager side of heartbeat from ResourceManager
> -------------------------------------------------------------
>
>                 Key: FLINK-4354
>                 URL: https://issues.apache.org/jira/browse/FLINK-4354
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{ResourceManager}} initiates heartbeat messages via the {{RmLeaderID}}. 
> The {{TaskManager}} transmits its slot availability with each heartbeat. That 
> way, the RM will always know about available slots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to