gustavodemorais commented on code in PR #29583:
URL: https://github.com/apache/flink/pull/29583#discussion_r4483806418
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/StreamNonDeterministicUpdatePlanVisitor.java:
##########
@@ -731,7 +731,7 @@ private ImmutableBitSet requiredForUpdatingMultiJoinInput(
final int inputIndex,
final ImmutableBitSet localRequired,
final int inputFieldCount) {
- final List<int[]> uniqueKeys =
multiJoin.getUniqueKeysForInputs().get(inputIndex);
+ final List<int[]> uniqueKeys =
multiJoin.getUpsertKeysForInputs().get(inputIndex);
Review Comment:
Could we keep both keys with separate meanings instead of replacing unique
keys everywhere? Unique keys stay for the state layout of retract inputs
(FLINK-38209), and upsert keys decide which inputs may drop UPDATE_BEFORE, plus
the state key and lookup of those inputs. Then retract inputs and old plans
keep their state layout and NDU behaviour, and inputKeys doesn't have to mean
two things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
