gustavodemorais commented on code in PR #29583:
URL: https://github.com/apache/flink/pull/29583#discussion_r4496677340
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMultiJoinOperator.java:
##########
@@ -406,10 +432,93 @@ public void processElement(int inputId,
StreamRecord<RowData> element) throws Ex
return;
}
+ if (isUpsert(input)) {
+ final RowData replacedRecord = replacedRecord(input, inputId);
Review Comment:
The join key is now computed up to three times per upsert record. Could we
compute it once here and pass it down?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMultiJoin.java:
##########
@@ -197,6 +199,16 @@ public ExecNode<?> translateToExecNode() {
multijoinCondition,
joinAttributeMap,
localInputUniqueKeys,
+ IntStream.range(0, inputs.size())
+ .mapToObj(this::getUpsertKeysContainingJoinKey)
Review Comment:
EXPLAIN only prints `inputUniqueKeys`, but upsert inputs are stored by these
upsert keys. Could we print the keys actually used, like the binary join's
`leftInputSpec`/`rightInputSpec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
