rionmonster commented on code in PR #29583:
URL: https://github.com/apache/flink/pull/29583#discussion_r4486659619
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/StreamNonDeterministicUpdatePlanVisitor.java:
##########
@@ -731,7 +731,7 @@ private ImmutableBitSet requiredForUpdatingMultiJoinInput(
final int inputIndex,
final ImmutableBitSet localRequired,
final int inputFieldCount) {
- final List<int[]> uniqueKeys =
multiJoin.getUniqueKeysForInputs().get(inputIndex);
+ final List<int[]> uniqueKeys =
multiJoin.getUpsertKeysForInputs().get(inputIndex);
Review Comment:
Sure, I think the distinction makes sense and makes things easier to follow
in this case. I'll keep the unique ones as they are and use the upsert keys as
it relates to the inputs that leverage `UPDATE_BEFORE` and how they are
keyed/looked up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
